mchades commented on code in PR #7877:
URL: https://github.com/apache/gravitino/pull/7877#discussion_r2261857218
##########
.github/workflows/build.yml:
##########
@@ -63,7 +63,9 @@ jobs:
cache: 'gradle'
- name: Build with Gradle
- run: ./gradlew build -x test -PjdkVersion=8
+ run: |
+ ./gradlew build -x test
+ ./gradlew build -PclientCompatibleWithJDK8 -x test
Review Comment:
Does JDK11 need to be tested?
##########
catalogs/catalog-common/src/main/java/org/apache/gravitino/credential/config/AzureCredentialConfig.java:
##########
@@ -84,32 +83,26 @@ public AzureCredentialConfig(Map<String, String>
properties) {
loadFromMap(properties, k -> true);
}
- @NotNull
Review Comment:
why remove the annotation?
##########
docs/how-to-build.md:
##########
@@ -12,14 +12,14 @@ license: "This software is licensed under the Apache
License version 2."
+ Linux or macOS operating system
+ Git
-+ A Java Development Kit, version 8 to 17, installed in your environment to
launch Gradle
++ A Java Development Kit, version 17 or higher, installed in your environment
to launch Gradle
+ Python 3.8, 3.9, 3.10, 3.11, or 3.12 to build the Gravitino Python client
+ Optionally, Docker to run integration tests
:::info Please read the following notes before trying to build Gravitino.
-+ Gravitino requires a minimum of JDK8 and supports up to JDK17 to run Gradle,
so you need to install a JDK, version 8 to 17, to launch the build environment.
-+ Gravitino itself supports using JDK 8, 11, or 17 to build. The Gravitino
Trino connector uses JDK17 to build (to avoid vendor-related issues on some
platforms, Gravitino uses the specified Amazon Corretto OpenJDK 17 to build the
Trino connector on macOS).
++ Gravitino requires a minimum of JDK17 to run Gradle, so you need to install
a JDK17 to launch the build environment.
Review Comment:
What is the exact meaning of "Gravitino"? Does it refer to both the client
and the server? Can JDK 11 be used to set up the server?
##########
docs/how-to-build.md:
##########
@@ -12,14 +12,14 @@ license: "This software is licensed under the Apache
License version 2."
+ Linux or macOS operating system
+ Git
-+ A Java Development Kit, version 8 to 17, installed in your environment to
launch Gradle
++ A Java Development Kit, version 17 or higher, installed in your environment
to launch Gradle
Review Comment:
Do we support a JDK version higher than JDK 17?
The code comment in `build.gradle.kts` states that Spotless does not work
with JDK 21:
> // Spotless version < 6.19.0
(https://github.com/diffplug/spotless/issues/1819) has an issue
> // running against JDK21, but we cannot upgrade the spotless to 6.19.0
or later since it only
> // support JDK11+. So we don't support JDK21 and thrown an exception for
now.
##########
build.gradle.kts:
##########
@@ -44,14 +44,12 @@ plugins {
// Spotless version < 6.19.0
(https://github.com/diffplug/spotless/issues/1819) has an issue
// running against JDK21, but we cannot upgrade the spotless to 6.19.0 or
later since it only
// support JDK11+. So we don't support JDK21 and thrown an exception for now.
- if (JavaVersion.current() >= JavaVersion.VERSION_1_8 &&
- JavaVersion.current() <= JavaVersion.VERSION_17
- ) {
+ if (JavaVersion.current() >= JavaVersion.VERSION_17) {
alias(libs.plugins.spotless)
} else {
throw GradleException(
"The Gravitino Gradle toolchain currently does not support " +
- "Java version ${JavaVersion.current()}. Please use JDK versions 8
through 17."
+ "Java version ${JavaVersion.current()}. Please use JDK version 17 or
higher."
Review Comment:
Is JDK 11 also not allowed?
##########
bundles/aliyun/build.gradle.kts:
##########
@@ -26,13 +26,13 @@ plugins {
dependencies {
compileOnly(project(":api"))
- compileOnly(project(":catalogs:catalog-common"))
- compileOnly(project(":catalogs:catalog-fileset"))
- compileOnly(project(":core"))
compileOnly(libs.hadoop3.client.api)
compileOnly(libs.hadoop3.client.runtime)
compileOnly(libs.hadoop3.oss)
+ implementation(project(":common")) {
Review Comment:
They used `compileOnly` before. Why do we need `implementation` now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
