diqiu50 commented on code in PR #7877:
URL: https://github.com/apache/gravitino/pull/7877#discussion_r2244914327
##########
build.gradle.kts:
##########
@@ -284,10 +346,12 @@ subprojects {
vendor.set(JvmVendorSpec.AMAZON)
}
languageVersion.set(JavaLanguageVersion.of(17))
- } else {
-
languageVersion.set(JavaLanguageVersion.of(extra["jdkVersion"].toString().toInt()))
+ } else if (CompatibleWithJDK8(project)) {
+ languageVersion.set(JavaLanguageVersion.of(17))
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
Review Comment:
My idea is to use JDK 17 for normal builds and running tests, without
generating JDK 8 compatible code. When the release8 parameter is added, JDK 8
compatible code will be generated for the client build, and tests will be
skipped in this case.
Build & Release Process Summary
The build process includes two steps:
1. Build with Java 17 (full build with tests)
```
./gradlew build
```
Runs all tests
Packages all modules
Produces Java 17 bytecode
2. Build Java 8-compatible client (skip tests)
```
./gradlew build -Drelease8 -x test
```
Skips tests
Builds only the client module
Produces Java 8-compatible artifacts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
