Re: [PR] [#6566] improvement(core): Add the cache mechanism for metalake and use cache to load `in-use` information. [gravitino]

[via GitHub]

yuqi1129 commented on code in PR #6569:
URL: https://github.com/apache/gravitino/pull/6569#discussion_r1978706464


##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -260,7 +260,7 @@ private ModelCatalog asModels() {
 
   private final Config config;
 
-  @VisibleForTesting final Cache<NameIdentifier, CatalogWrapper> catalogCache;
+  @VisibleForTesting static Cache<NameIdentifier, CatalogWrapper> catalogCache;

Review Comment:
   If we use `static final` flag, then Gravitino server configuraoin like 
`gravitino.catalog.cache.evictionIntervalMs` should be remove as we can't used 
it in static code block, Is that acceptable to you?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org