Re: [PR] [#6566] improvement(core): Add the cache mechanism for metalake and use cache to load `in-use` information. [gravitino]

[via GitHub]

jerryshao commented on code in PR #6569:
URL: https://github.com/apache/gravitino/pull/6569#discussion_r1984568412


##########
core/src/main/java/org/apache/gravitino/metalake/MetalakeManager.java:
##########
@@ -149,20 +185,23 @@ public BaseMetalake[] listMetalakes() {
    */
   @Override
   public BaseMetalake loadMetalake(NameIdentifier ident) throws 
NoSuchMetalakeException {
-    try {
-      BaseMetalake baseMetalake =
-          TreeLockUtils.doWithTreeLock(
-              ident,
-              LockType.READ,
-              () -> store.get(ident, EntityType.METALAKE, BaseMetalake.class));
-      return newMetalakeWithResolvedProperties(baseMetalake);
-    } catch (NoSuchEntityException e) {
-      LOG.warn("Metalake {} does not exist", ident, e);
-      throw new NoSuchMetalakeException(METALAKE_DOES_NOT_EXIST_MSG, ident);
-    } catch (IOException ioe) {
-      LOG.error("Loading Metalake {} failed due to storage issues", ident, 
ioe);
-      throw new RuntimeException(ioe);
-    }
+    return TreeLockUtils.doWithTreeLock(
+        ident,
+        LockType.READ,
+        () -> {
+          try {
+            BaseMetalake baseMetalake = store.get(ident, EntityType.METALAKE, 
BaseMetalake.class);

Review Comment:
   Why do we still need to get the metalake from store, rather than from cache? 
With your code, what's the meaning of `METALAKE_CACHE.put(ident, baseMetalake)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org