FANNG1 commented on code in PR #6470:
URL: https://github.com/apache/gravitino/pull/6470#discussion_r1967888908
##########
core/src/main/java/org/apache/gravitino/storage/relational/session/SqlSessionFactoryHelper.java:
##########
@@ -102,6 +105,8 @@ public void init(Config config) {
dataSource.setSoftMinEvictableIdleTimeMillis(
BaseObjectPoolConfig.DEFAULT_SOFT_MIN_EVICTABLE_IDLE_TIME.toMillis());
dataSource.setLifo(BaseObjectPoolConfig.DEFAULT_LIFO);
+ MetricsSystem metricsSystem = GravitinoEnv.getInstance().metricsSystem();
Review Comment:
How about checking the nullable of `metricsSystem` to avoid too many changes
in the test? and add some comments about why adding the nullable check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
