FANNG1 commented on code in PR #5847: URL: https://github.com/apache/gravitino/pull/5847#discussion_r1888493314
########## core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java: ########## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.listener; + +import java.util.Map; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.exceptions.NoSuchTagException; +import org.apache.gravitino.tag.Tag; +import org.apache.gravitino.tag.TagChange; +import org.apache.gravitino.tag.TagDispatcher; + +/** + * {@code TagEventDispatcher} is a decorator for {@link TagDispatcher} that not only delegates tag + * operations to the underlying tag dispatcher but also dispatches corresponding events to an {@link + * EventBus} after each operation is completed. This allows for event-driven workflows or monitoring + * of tag operations. + */ +public class TagEventDispatcher implements TagDispatcher { + @SuppressWarnings("unused") + private final EventBus eventBus; + + @SuppressWarnings("unused") + private final TagDispatcher dispatcher; + + public TagEventDispatcher(EventBus eventBus, TagDispatcher dispatcher) { + this.eventBus = eventBus; + this.dispatcher = dispatcher; + } + + @Override + public String[] listTags(String metalake) { + // TODO: listTagsPreEvent + try { + // TODO: listTagsEvent + } catch (Exception e) { + // TODO: listTagFailureEvent + throw e; + } + return dispatcher.listTags(metalake); Review Comment: `return dispatcher.listTags(metalake);` should in `try` block, similar issues to other operations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
