TungYuChiang commented on code in PR #5847: URL: https://github.com/apache/gravitino/pull/5847#discussion_r1883903671
########## api/src/main/java/org/apache/gravitino/SupportsTags.java: ########## @@ -17,11 +17,12 @@ * under the License. */ -package org.apache.gravitino.tag; +package org.apache.gravitino; import org.apache.gravitino.annotation.Evolving; import org.apache.gravitino.exceptions.NoSuchTagException; import org.apache.gravitino.exceptions.TagAlreadyAssociatedException; +import org.apache.gravitino.tag.Tag; Review Comment: If we do not move the Supports in the API module, it will conflict with the one in the core module. I referred to other designs under the API, such as catalog, and moved it out of the Tag folder. Would you happen to have any good suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org