yuqi1129 commented on code in PR #4232:
URL: https://github.com/apache/gravitino/pull/4232#discussion_r1708481138
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/AuthenticationConfig.java:
##########
@@ -36,7 +36,8 @@ public class AuthenticationConfig extends Config {
enum AuthenticationType {
SIMPLE,
- KERBEROS;
+ KERBEROS,
+ AWS;
Review Comment:
> That's actually correct. But I'm worried that we are introducing too much
values for `AuthenticationType` in this way, as we may support more storage
types in the future, are you ok with this?
Introducing too many authentication types is indeed a problem, but `AWS` or
`S3` is a service or product name NOT an authentication type, It's also not
very proper to use it. @xiaozcy @jerqi Do you have any other good ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
