xiaozcy commented on code in PR #4232:
URL: https://github.com/apache/gravitino/pull/4232#discussion_r1708473415
##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/AuthenticationConfig.java:
##########
@@ -36,7 +36,8 @@ public class AuthenticationConfig extends Config {
enum AuthenticationType {
SIMPLE,
- KERBEROS;
+ KERBEROS,
+ AWS;
Review Comment:
@yuqi1129
> From my perspective, does the type seem to be AWS_AKSK, AWS_ANONYMOUS and
AWS_TEMPORARY? Please correct me if I am mistaken.
That's actually correct. But I'm worried that we are introducing too much
values for `AuthenticationType` in this way, as we may support more storage
types in the future, are you ok with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
