Re: [PR] [#3379] feat(catalog-hadoop): Add S3 support for Fileset Hadoop catalog [gravitino]

Wed, 07 Aug 2024 19:49:47 -0700 


xiaozcy commented on code in PR #4232:
URL: https://github.com/apache/gravitino/pull/4232#discussion_r1708476737


##########
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/AuthenticationConfig.java:
##########
@@ -36,7 +36,8 @@ public class AuthenticationConfig extends Config {
 
   enum AuthenticationType {
     SIMPLE,
-    KERBEROS;
+    KERBEROS,
+    AWS;

Review Comment:
   @jerqi 
   > Does AWS have anonnymous?
   
   Yes, you can refer to this.
   
![image](https://github.com/user-attachments/assets/2c0688f7-6899-4ac2-9a8d-1752c3a369e0)
   
   
   > TEMPORARY may be inaccurate.Maybe we should use token.
   
   I use `temporary` because the name of the provider is 
`TemporaryAWSCredentialsProvider`, I'm also ok with the name `token`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to