FrankChen021 commented on code in PR #19372:
URL: https://github.com/apache/druid/pull/19372#discussion_r3168201885
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -4255,6 +4418,23 @@ private OrderedSequenceNumber<SequenceOffsetType>
getOffsetFromStorageForPartiti
}
Review Comment:
I agree the source of the metadata is the hard part here, but I would avoid
using "metadata is within the configured start/end range" as the deciding rule.
If the stored offset is inside `[start, end)`, starting there can still
silently skip the prefix `[start, storedOffset)`, which is the same class of
surprise as the original issue. I think the safer behavior is still to fail
fast when bounded mode finds existing metadata for the configured bounded
partitions unless there is an explicit signal that this is a resume of the same
bounded run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
