capistrant commented on code in PR #19223:
URL: https://github.com/apache/druid/pull/19223#discussion_r3076678884
##########
indexing-service/src/main/java/org/apache/druid/indexing/compact/OverlordCompactionScheduler.java:
##########
@@ -264,6 +266,8 @@ public CompactionConfigValidationResult
validateCompactionConfig(DataSourceCompa
{
if (compactionConfig == null) {
return CompactionConfigValidationResult.failure("Cannot be null");
+ } else if (compactionConfig instanceof CascadingReindexingTemplate) {
Review Comment:
@gianm ok I tinkered with things to get the validation out of the
constructor and into POST time, plus other status/state checks for the
supervisor. net it gets it out of only checking during deserialization and now
is much more responsive in surfacing config changes that make a spec
invalid/valid. before you would need a failover, service restart, etc. to get
the status to reflect the change in the supervisor data. now it is pretty
rapidly reflective of the actual state
let me know if this feels more in the right direction, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
