capistrant commented on code in PR #19223:
URL: https://github.com/apache/druid/pull/19223#discussion_r3016702605
##########
indexing-service/src/main/java/org/apache/druid/indexing/compact/OverlordCompactionScheduler.java:
##########
@@ -264,6 +266,8 @@ public CompactionConfigValidationResult
validateCompactionConfig(DataSourceCompa
{
if (compactionConfig == null) {
return CompactionConfigValidationResult.failure("Cannot be null");
+ } else if (compactionConfig instanceof CascadingReindexingTemplate) {
Review Comment:
> Wouldn't it be better to validate when we run the spec in
resetCompactionJobQueue, rather than on spec deserialization?
hmm this is a good point. I guess one downside is delayed feedback after
spec submission 🤔 . And for folks who specify an engine in spec they actually
don't depend on the cluster config so kind of sad to wait to get feedback. but
probably even worse is to have a spec that was good quietly become invalid if
the cluster config changes. so I suppose I've talked myself into moving it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
