capistrant commented on code in PR #19223:
URL: https://github.com/apache/druid/pull/19223#discussion_r3074271560
##########
indexing-service/src/main/java/org/apache/druid/indexing/compact/OverlordCompactionScheduler.java:
##########
@@ -264,6 +266,8 @@ public CompactionConfigValidationResult
validateCompactionConfig(DataSourceCompa
{
if (compactionConfig == null) {
return CompactionConfigValidationResult.failure("Cannot be null");
+ } else if (compactionConfig instanceof CascadingReindexingTemplate) {
Review Comment:
Did some local testing to get clarity on behavior -
It will not fail to show up. if a spec goes from valid to invalid because of
the dynamic config, the next time it is deserialized it will flip to
INVALID_SPEC state but still shows up. I'm still taking this suggestion under
advisement though. even if it isn't awful UX currently, I think you're on to
something in suggesting we rethink the location of validtion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
