jaykanakiya commented on code in PR #19258:
URL: https://github.com/apache/druid/pull/19258#discussion_r3066801893


##########
processing/src/main/java/org/apache/druid/segment/StringDimensionIndexer.java:
##########
@@ -68,7 +67,7 @@ public StringDimensionIndexer(
       boolean hasSpatialIndexes
   )
   {
-    this(multiValueHandling, hasBitmapIndexes, hasSpatialIndexes, 
StringDimensionSchema.getDefaultMaxStringLength());
+    this(multiValueHandling, hasBitmapIndexes, hasSpatialIndexes, null);

Review Comment:
   Updated to use BuiltInTypesModule. 



##########
processing/src/main/java/org/apache/druid/segment/StringDimensionHandler.java:
##########
@@ -115,7 +115,7 @@ public StringDimensionHandler(
       boolean hasSpatialIndexes
   )
   {
-    this(dimensionName, multiValueHandling, hasBitmapIndexes, 
hasSpatialIndexes, StringDimensionSchema.getDefaultMaxStringLength());
+    this(dimensionName, multiValueHandling, hasBitmapIndexes, 
hasSpatialIndexes, null);

Review Comment:
   Updated. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to