aho135 commented on code in PR #19258:
URL: https://github.com/apache/druid/pull/19258#discussion_r3055497469
##########
processing/src/main/java/org/apache/druid/data/input/impl/StringDimensionSchema.java:
##########
@@ -117,6 +118,29 @@ public boolean canBeMultiValued()
@Override
public DimensionHandler getDimensionHandler()
{
+ Integer maxStringLength = columnFormatSpec != null ?
columnFormatSpec.getMaxStringLength() : null;
Review Comment:
Leaving a comment so I can revisit this tomorrow. Why do we only pass in
maxStringLength here, but use parent defaults for
createBitmapIndex/multiValueHandling?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
