clintropolis commented on code in PR #19258:
URL: https://github.com/apache/druid/pull/19258#discussion_r3066129034
##########
processing/src/main/java/org/apache/druid/data/input/impl/StringDimensionSchema.java:
##########
@@ -117,6 +118,29 @@ public boolean canBeMultiValued()
@Override
public DimensionHandler getDimensionHandler()
{
+ Integer maxStringLength = columnFormatSpec != null ?
columnFormatSpec.getMaxStringLength() : null;
Review Comment:
yea, I think we should get all of the things from the formatSpec if they are
defined there, and fallback to the parent if not set
##########
processing/src/main/java/org/apache/druid/segment/IndexSpec.java:
##########
@@ -298,6 +312,16 @@ public IndexSpec getEffectiveSpec()
);
}
+ if (stringColumnFormatSpec != null) {
+ bob.withStringColumnFormatSpec(
+
StringColumnFormatSpec.getEffectiveFormatSpec(stringColumnFormatSpec, this)
+ );
+ } else if (defaultSpec.stringColumnFormatSpec != null) {
+ bob.withStringColumnFormatSpec(
Review Comment:
defautlSpec can be set in runtime.properties to set system level default
overrides, so we want it to be like this i think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
