kgyrtkirk commented on code in PR #19249:
URL: https://github.com/apache/druid/pull/19249#discussion_r3023917292
##########
services/src/test/java/org/apache/druid/testing/embedded/EmbeddedDruidServer.java:
##########
@@ -73,8 +73,12 @@ protected EmbeddedDruidServer()
);
beforeStartHooks.add(
(cluster, self) -> {
- // Add properties for temporary directories used by the servers
- final String logsDirectory =
cluster.getTestFolder().getOrCreateFolder("indexer-logs").getAbsolutePath();
+ // Add properties for temporary directories used by the servers.
+ // If task.logs.dir is set, write indexer logs there so they survive
TestFolder cleanup.
Review Comment:
this doesn't change the default behaviour - but it was necessary to capture
the task logs during my check runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
