gianm commented on code in PR #19249: URL: https://github.com/apache/druid/pull/19249#discussion_r3023364914
########## .github/scripts/run-stability: ########## @@ -0,0 +1,60 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +set -e Review Comment: Please include a comment about what the purpose of this script is. ########## extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3StorageDruidModule.java: ########## @@ -191,15 +194,17 @@ public ServerSideEncryptingAmazonS3.Builder getServerSideEncryptingAmazonS3Build }; // Create async client supplier for S3TransferManager + final String asyncHttpClientType = storageConfig.getS3TransferConfig().getAsyncHttpClientType(); + if (!"crt".equalsIgnoreCase(asyncHttpClientType) && !"netty".equalsIgnoreCase(asyncHttpClientType)) { Review Comment: Rather than hard coding these strings inline, would be nicer to use an enum, or at least a `public static final Set<String>`. ########## services/src/test/java/org/apache/druid/testing/embedded/EmbeddedDruidServer.java: ########## @@ -73,8 +73,12 @@ protected EmbeddedDruidServer() ); beforeStartHooks.add( (cluster, self) -> { - // Add properties for temporary directories used by the servers - final String logsDirectory = cluster.getTestFolder().getOrCreateFolder("indexer-logs").getAbsolutePath(); + // Add properties for temporary directories used by the servers. + // If task.logs.dir is set, write indexer logs there so they survive TestFolder cleanup. Review Comment: Why do we want logs to survive TestFolder cleanup? Generally it's good for tests to clean up any files they wrote, otherwise the system can get littered with junk files. If there's a good reason for this the comment should say it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
