kgyrtkirk commented on code in PR #19249:
URL: https://github.com/apache/druid/pull/19249#discussion_r3024046169
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3StorageDruidModule.java:
##########
@@ -191,15 +194,17 @@ public ServerSideEncryptingAmazonS3.Builder
getServerSideEncryptingAmazonS3Build
};
// Create async client supplier for S3TransferManager
+ final String asyncHttpClientType =
storageConfig.getS3TransferConfig().getAsyncHttpClientType();
+ if (!"crt".equalsIgnoreCase(asyncHttpClientType) &&
!"netty".equalsIgnoreCase(asyncHttpClientType)) {
Review Comment:
added an `enum`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
