yiguolei commented on code in PR #18627: URL: https://github.com/apache/doris/pull/18627#discussion_r1166254665
########## be/src/vec/functions/function_rpc.cpp: ########## @@ -316,6 +317,7 @@ void RPCFnImpl::convert_col_to_pvalue(const ColumnPtr& column, const DataTypePtr } } +// (Todo.Amory) need to delete here template <bool nullable> Review Comment: 这个 nullable 模板参数是没用的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org