yiguolei commented on code in PR #18627: URL: https://github.com/apache/doris/pull/18627#discussion_r1166252568
########## be/src/vec/data_types/serde/data_type_decimal_serde.h: ########## @@ -0,0 +1,64 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "data_type_serde.h" +#include "vec/columns/column_decimal.h" + +namespace doris { + +namespace vectorized { + +template <typename T> +class DataTypeDecimalSerDe : public DataTypeSerDe { + static_assert(IsDecimalNumber<T>); + +public: + Status write_column_to_pb(const IColumn& column, PValues& result, int start, int end) const override; + Status read_column_from_pb(IColumn& column, const PValues& arg) const override; +}; + +template <typename T> +Status DataTypeDecimalSerDe<T>::write_column_to_pb(const IColumn& column, PValues& result, + int start, int end) const { + int row_count = end - start; + const auto* col = check_and_get_column<ColumnDecimal<T>>(column); + if constexpr (std::is_same_v<T, Decimal<Int128>>) { Review Comment: forget decimal32,64,128i -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
