yiguolei commented on code in PR #18627:
URL: https://github.com/apache/doris/pull/18627#discussion_r1166168681
##########
be/src/vec/data_types/data_type_struct.h:
##########
@@ -99,6 +100,14 @@ class DataTypeStruct final : public IDataType {
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
bool get_have_explicit_names() const { return have_explicit_names; }
+ DataTypeSerDeSPtr get_serde() const override {
+ DataTypeSerDeSPtrs ptrs;
+ ptrs.reserve(elems.size());
Review Comment:
这种代码实际没啥用。。。 这里不是很关键，不会有性能问题的，但是多余写的reserve这种逻辑，后期重构或者改可能会改错
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
