github-actions[bot] commented on code in PR #16996:
URL: https://github.com/apache/doris/pull/16996#discussion_r1113714847


##########
be/src/runtime/routine_load/routine_load_task_executor.h:
##########
@@ -40,7 +41,7 @@ class TRoutineLoadTask;
 // to FE finally.
 class RoutineLoadTaskExecutor {
 public:
-    typedef std::function<void(StreamLoadContext*)> ExecFinishCallback;
+    using ExecFinishCallback = std::function<void 
(std::shared_ptr<StreamLoadContext>)>;

Review Comment:
   warning: use 'using' instead of 'typedef' [modernize-use-using]
   
   ```suggestion
       using ExecFinishCallback = std::function<void 
(std::shared_ptr<StreamLoadContext>)>;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to