github-actions[bot] commented on code in PR #16996:
URL: https://github.com/apache/doris/pull/16996#discussion_r1112984522
##########
be/src/runtime/routine_load/data_consumer.h:
##########
@@ -123,18 +121,19 @@
}
}
- virtual Status init(StreamLoadContext* ctx) override;
+ virtual Status init(std::shared_ptr<StreamLoadContext> ctx) override;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status init(std::shared_ptr<StreamLoadContext> ctx) override;
```
##########
be/src/runtime/routine_load/data_consumer.h:
##########
@@ -123,18 +121,19 @@
}
}
- virtual Status init(StreamLoadContext* ctx) override;
+ virtual Status init(std::shared_ptr<StreamLoadContext> ctx) override;
// TODO(cmy): currently do not implement single consumer start method,
using group_consume
- virtual Status consume(StreamLoadContext* ctx) override { return
Status::OK(); }
- virtual Status cancel(StreamLoadContext* ctx) override;
+ virtual Status consume(std::shared_ptr<StreamLoadContext> ctx) override {
return Status::OK(); }
+ virtual Status cancel(std::shared_ptr<StreamLoadContext> ctx) override;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status cancel(std::shared_ptr<StreamLoadContext> ctx) override;
```
##########
be/src/runtime/routine_load/data_consumer.h:
##########
@@ -109,10 +109,8 @@ class KafkaEventCb : public RdKafka::EventCb {
class KafkaDataConsumer : public DataConsumer {
public:
- KafkaDataConsumer(StreamLoadContext* ctx)
- : DataConsumer(ctx),
- _brokers(ctx->kafka_info->brokers),
- _topic(ctx->kafka_info->topic) {}
+ KafkaDataConsumer(std::shared_ptr<StreamLoadContext> ctx)
+ : DataConsumer(), _brokers(ctx->kafka_info->brokers),
_topic(ctx->kafka_info->topic) {}
Review Comment:
warning: initializer for base class 'doris::DataConsumer' is redundant
[readability-redundant-member-init]
```suggestion
: , _brokers(ctx->kafka_info->brokers),
_topic(ctx->kafka_info->topic) {}
```
##########
be/src/runtime/routine_load/routine_load_task_executor.h:
##########
@@ -40,7 +41,7 @@ class TRoutineLoadTask;
// to FE finally.
class RoutineLoadTaskExecutor {
public:
- typedef std::function<void(StreamLoadContext*)> ExecFinishCallback;
+ typedef std::function<void(std::shared_ptr<StreamLoadContext>)>
ExecFinishCallback;
Review Comment:
warning: use 'using' instead of 'typedef' [modernize-use-using]
```suggestion
using ExecFinishCallback = std::function<void
(std::shared_ptr<StreamLoadContext>)>;
```
##########
be/src/runtime/routine_load/data_consumer_group.h:
##########
@@ -68,9 +68,9 @@ class KafkaDataConsumerGroup : public DataConsumerGroup {
virtual ~KafkaDataConsumerGroup();
- virtual Status start_all(StreamLoadContext* ctx) override;
+ virtual Status start_all(std::shared_ptr<StreamLoadContext> ctx) override;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status start_all(std::shared_ptr<StreamLoadContext> ctx) override;
```
##########
be/src/runtime/routine_load/data_consumer.h:
##########
@@ -123,18 +121,19 @@
}
}
- virtual Status init(StreamLoadContext* ctx) override;
+ virtual Status init(std::shared_ptr<StreamLoadContext> ctx) override;
// TODO(cmy): currently do not implement single consumer start method,
using group_consume
- virtual Status consume(StreamLoadContext* ctx) override { return
Status::OK(); }
- virtual Status cancel(StreamLoadContext* ctx) override;
+ virtual Status consume(std::shared_ptr<StreamLoadContext> ctx) override {
return Status::OK(); }
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status consume(std::shared_ptr<StreamLoadContext> ctx) override { return
Status::OK(); }
```
##########
be/src/runtime/routine_load/data_consumer.h:
##########
@@ -123,18 +121,19 @@
}
}
- virtual Status init(StreamLoadContext* ctx) override;
+ virtual Status init(std::shared_ptr<StreamLoadContext> ctx) override;
// TODO(cmy): currently do not implement single consumer start method,
using group_consume
- virtual Status consume(StreamLoadContext* ctx) override { return
Status::OK(); }
- virtual Status cancel(StreamLoadContext* ctx) override;
+ virtual Status consume(std::shared_ptr<StreamLoadContext> ctx) override {
return Status::OK(); }
+ virtual Status cancel(std::shared_ptr<StreamLoadContext> ctx) override;
// reassign partition topics
virtual Status reset() override;
- virtual bool match(StreamLoadContext* ctx) override;
+ virtual bool match(std::shared_ptr<StreamLoadContext> ctx) override;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
bool match(std::shared_ptr<StreamLoadContext> ctx) override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
