github-actions[bot] commented on code in PR #16996:
URL: https://github.com/apache/doris/pull/16996#discussion_r1113714749
##########
be/src/runtime/routine_load/data_consumer.h:
##########
@@ -123,18 +121,19 @@
}
}
- virtual Status init(StreamLoadContext* ctx) override;
+ Status init(std::shared_ptr<StreamLoadContext> ctx) override;
// TODO(cmy): currently do not implement single consumer start method,
using group_consume
- virtual Status consume(StreamLoadContext* ctx) override { return
Status::OK(); }
- virtual Status cancel(StreamLoadContext* ctx) override;
+ Status consume(std::shared_ptr<StreamLoadContext> ctx) override { return
Status::OK(); }
+ Status cancel(std::shared_ptr<StreamLoadContext> ctx) override;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status cancel(std::shared_ptr<StreamLoadContext> ctx) override;
```
##########
be/src/runtime/routine_load/data_consumer.h:
##########
@@ -123,18 +121,19 @@
}
}
- virtual Status init(StreamLoadContext* ctx) override;
+ Status init(std::shared_ptr<StreamLoadContext> ctx) override;
// TODO(cmy): currently do not implement single consumer start method,
using group_consume
- virtual Status consume(StreamLoadContext* ctx) override { return
Status::OK(); }
- virtual Status cancel(StreamLoadContext* ctx) override;
+ Status consume(std::shared_ptr<StreamLoadContext> ctx) override { return
Status::OK(); }
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status consume(std::shared_ptr<StreamLoadContext> ctx) override { return
Status::OK(); }
```
##########
be/src/runtime/routine_load/data_consumer.h:
##########
@@ -109,10 +109,8 @@ class KafkaEventCb : public RdKafka::EventCb {
class KafkaDataConsumer : public DataConsumer {
public:
- KafkaDataConsumer(StreamLoadContext* ctx)
- : DataConsumer(ctx),
- _brokers(ctx->kafka_info->brokers),
- _topic(ctx->kafka_info->topic) {}
+ KafkaDataConsumer(std::shared_ptr<StreamLoadContext> ctx)
+ : , _brokers(ctx->kafka_info->brokers),
_topic(ctx->kafka_info->topic) {}
Review Comment:
warning: expected class member or base class name [clang-diagnostic-error]
```cpp
: , _brokers(ctx->kafka_info->brokers),
_topic(ctx->kafka_info->topic) {}
^
```
##########
be/src/runtime/routine_load/data_consumer_group.h:
##########
@@ -68,9 +68,9 @@ class KafkaDataConsumerGroup : public DataConsumerGroup {
virtual ~KafkaDataConsumerGroup();
- virtual Status start_all(StreamLoadContext* ctx) override;
+ Status start_all(std::shared_ptr<StreamLoadContext> ctx) override;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status start_all(std::shared_ptr<StreamLoadContext> ctx) override;
```
##########
be/src/runtime/routine_load/data_consumer.h:
##########
@@ -123,18 +121,19 @@
}
}
- virtual Status init(StreamLoadContext* ctx) override;
+ Status init(std::shared_ptr<StreamLoadContext> ctx) override;
// TODO(cmy): currently do not implement single consumer start method,
using group_consume
- virtual Status consume(StreamLoadContext* ctx) override { return
Status::OK(); }
- virtual Status cancel(StreamLoadContext* ctx) override;
+ Status consume(std::shared_ptr<StreamLoadContext> ctx) override { return
Status::OK(); }
+ Status cancel(std::shared_ptr<StreamLoadContext> ctx) override;
// reassign partition topics
virtual Status reset() override;
- virtual bool match(StreamLoadContext* ctx) override;
+ bool match(std::shared_ptr<StreamLoadContext> ctx) override;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
bool match(std::shared_ptr<StreamLoadContext> ctx) override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
