github-actions[bot] commented on code in PR #16731:
URL: https://github.com/apache/doris/pull/16731#discussion_r1112715214
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -116,17 +118,17 @@ Status BetaRowsetWriter::add_block(const
vectorized::Block* block) {
return _add_block(block, &_segment_writer);
}
-vectorized::VMergeIterator* BetaRowsetWriter::_get_segcompaction_reader(
- SegCompactionCandidatesSharedPtr segments, std::shared_ptr<Schema>
schema,
- OlapReaderStatistics* stat, uint64_t* merged_row_stat) {
+std::unique_ptr<vectorized::VerticalBlockReader>
BetaRowsetWriter::_get_segcompaction_reader(
Review Comment:
warning: method '_get_segcompaction_reader' can be made const
[readability-make-member-function-const]
be/src/olap/rowset/beta_rowset_writer.cpp:122:
```diff
- std::shared_ptr<Schema> schema, OlapReaderStatistics* stat,
uint64_t* merged_row_stat, vectorized::RowSourcesBuffer& row_sources_buf, bool
is_key, std::vector<uint32_t>& return_columns) {
+ std::shared_ptr<Schema> schema, OlapReaderStatistics* stat,
uint64_t* merged_row_stat, vectorized::RowSourcesBuffer& row_sources_buf, bool
is_key, std::vector<uint32_t>& return_columns) const { const
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
