github-actions[bot] commented on code in PR #16731:
URL: https://github.com/apache/doris/pull/16731#discussion_r1115277020
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -116,9 +118,12 @@ Status BetaRowsetWriter::add_block(const
vectorized::Block* block) {
return _add_block(block, &_segment_writer);
}
-RowwiseIteratorUPtr BetaRowsetWriter::_get_segcompaction_reader(
- SegCompactionCandidatesSharedPtr segments, std::shared_ptr<Schema>
schema,
- OlapReaderStatistics* stat, uint64_t* merged_row_stat) {
+Status BetaRowsetWriter::_get_segcompaction_reader(
Review Comment:
warning: method '_get_segcompaction_reader' can be made const
[readability-make-member-function-const]
be/src/olap/rowset/beta_rowset_writer.cpp:125:
```diff
- std::unique_ptr<vectorized::VerticalBlockReader>* reader) {
+ std::unique_ptr<vectorized::VerticalBlockReader>* reader) const {
```
be/src/olap/rowset/beta_rowset_writer.h:121:
```diff
-
std::unique_ptr<vectorized::VerticalBlockReader>* reader);
+
std::unique_ptr<vectorized::VerticalBlockReader>* reader) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
