github-actions[bot] commented on code in PR #16731:
URL: https://github.com/apache/doris/pull/16731#discussion_r1105344483
##########
be/src/olap/base_tablet.h:
##########
@@ -36,6 +36,7 @@ class DataDir;
class BaseTablet : public std::enable_shared_from_this<BaseTablet> {
public:
BaseTablet(TabletMetaSharedPtr tablet_meta, DataDir* data_dir);
+ BaseTablet() {};
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```suggestion
BaseTablet() = default;;
```
##########
be/src/olap/tablet.h:
##########
@@ -67,7 +67,7 @@ class Tablet : public BaseTablet {
Tablet(TabletMetaSharedPtr tablet_meta, DataDir* data_dir,
const std::string& cumulative_compaction_type = "");
-
+ Tablet() {};
Review Comment:
warning: use '= default' to define a trivial default constructor
[modernize-use-equals-default]
```suggestion
Tablet() = default;;
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -184,6 +187,27 @@
rowset_writer_context->tablet_schema = tablet_schema;
rowset_writer_context->version.first = 10;
rowset_writer_context->version.second = 10;
+
+#if 0
+ TCreateTabletReq req;
+ req.table_id =
+ req.tablet_id =
+ req.tablet_scheme =
+ req.partition_id =
+ l_engine->create_tablet(req);
+ rowset_writer_context->tablet =
l_engine->tablet_manager()->get_tablet(TTabletId tablet_id);
+#endif
+ std::shared_ptr<DataDir> data_dir =
std::make_shared<DataDir>(lTestDir);
+ TabletMetaSharedPtr tablet_meta = std::make_shared<TabletMeta>();
+ tablet_meta->_tablet_id = 1;
+ tablet_meta->_schema = tablet_schema;
+ auto tablet = std::make_shared<Tablet>(tablet_meta, data_dir.get(),
"test_str");
+ char *tmp_str = (char*)malloc(20);
+ strncpy(tmp_str, "test_tablet_name", 20);
+
+ tablet->_full_name = tmp_str;
Review Comment:
warning: '_full_name' is a protected member of 'doris::BaseTablet'
[clang-diagnostic-error]
```cpp
tablet->_full_name = tmp_str;
^
```
**be/src/olap/base_tablet.h:86:** declared protected here
```cpp
std::string _full_name;
^
```
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -114,17 +115,17 @@ Status BetaRowsetWriter::add_block(const
vectorized::Block* block) {
return _add_block(block, &_segment_writer);
}
-vectorized::VMergeIterator* BetaRowsetWriter::_get_segcompaction_reader(
- SegCompactionCandidatesSharedPtr segments, std::shared_ptr<Schema>
schema,
- OlapReaderStatistics* stat, uint64_t* merged_row_stat) {
+std::unique_ptr<vectorized::VerticalBlockReader>
BetaRowsetWriter::_get_segcompaction_reader(
Review Comment:
warning: method '_get_segcompaction_reader' can be made const
[readability-make-member-function-const]
be/src/olap/rowset/beta_rowset_writer.cpp:119:
```diff
- std::shared_ptr<Schema> schema, OlapReaderStatistics* stat,
uint64_t* merged_row_stat, vectorized::RowSourcesBuffer& row_sources_buf, bool
is_key, std::vector<uint32_t>& return_columns) {
+ std::shared_ptr<Schema> schema, OlapReaderStatistics* stat,
uint64_t* merged_row_stat, vectorized::RowSourcesBuffer& row_sources_buf, bool
is_key, std::vector<uint32_t>& return_columns) const {
```
```suggestion
vectorized::RowSourcesBuffer& row_sources_buf, bool is_key,
std::vector<uint32_t>& return_columns) const;
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -184,6 +187,27 @@
rowset_writer_context->tablet_schema = tablet_schema;
rowset_writer_context->version.first = 10;
rowset_writer_context->version.second = 10;
+
+#if 0
+ TCreateTabletReq req;
+ req.table_id =
+ req.tablet_id =
+ req.tablet_scheme =
+ req.partition_id =
+ l_engine->create_tablet(req);
+ rowset_writer_context->tablet =
l_engine->tablet_manager()->get_tablet(TTabletId tablet_id);
+#endif
+ std::shared_ptr<DataDir> data_dir =
std::make_shared<DataDir>(lTestDir);
+ TabletMetaSharedPtr tablet_meta = std::make_shared<TabletMeta>();
+ tablet_meta->_tablet_id = 1;
+ tablet_meta->_schema = tablet_schema;
Review Comment:
warning: '_schema' is a private member of 'doris::TabletMeta'
[clang-diagnostic-error]
```cpp
tablet_meta->_schema = tablet_schema;
^
```
**be/src/olap/tablet_meta.h:234:** declared private here
```cpp
TabletSchemaSPtr _schema;
^
```
##########
be/test/olap/segcompaction_test.cpp:
##########
@@ -184,6 +187,27 @@ class SegCompactionTest : public testing::Test {
rowset_writer_context->tablet_schema = tablet_schema;
rowset_writer_context->version.first = 10;
rowset_writer_context->version.second = 10;
+
+#if 0
+ TCreateTabletReq req;
+ req.table_id =
+ req.tablet_id =
+ req.tablet_scheme =
+ req.partition_id =
+ l_engine->create_tablet(req);
+ rowset_writer_context->tablet =
l_engine->tablet_manager()->get_tablet(TTabletId tablet_id);
+#endif
+ std::shared_ptr<DataDir> data_dir =
std::make_shared<DataDir>(lTestDir);
+ TabletMetaSharedPtr tablet_meta = std::make_shared<TabletMeta>();
+ tablet_meta->_tablet_id = 1;
Review Comment:
warning: '_tablet_id' is a private member of 'doris::TabletMeta'
[clang-diagnostic-error]
```cpp
tablet_meta->_tablet_id = 1;
^
```
**be/src/olap/tablet_meta.h:222:** declared private here
```cpp
int64_t _tablet_id = 0;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
