morningman commented on code in PR #69575:
URL: https://github.com/apache/doris/pull/69575#discussion_r4369204809
##########
fe/fe-core/src/main/java/org/apache/doris/journal/JournalEntity.java:
##########
@@ -913,6 +913,12 @@ public void readFields(DataInput in) throws IOException {
isRead = true;
break;
}
+ case OperationType.OP_LANCE_INDEX_JOB_UPSERT: {
+ // Text-framed JSON of the removed branch-4.x Lance index job
framework; consumed and ignored.
+ Text.readString(in);
Review Comment:
Confirmed, and fixed in `b0e09ae835e` in the debug reader rather than in the
tombstone. `BdbjeJournalDataProcNode` called `getData().toString()` without a
null check, and master already has twelve retired operation types whose records
are read without keeping a payload: the four PL/SQL ones that #58700 turned
into `Text.readString(in)` (the form this PR copies for op 500, as
branch-4.1/4.2 do) and eight external-catalog ones (329, 350–356) whose reader
keeps no payload either. `SHOW PROC '/bdbje/<db>/<journalId>'` on any of those
records already failed the same way. `BDBTool`, the other BDBJE inspection
path, prints a missing payload as `null`; the proc node now does the same
through `String.valueOf`, so op 500 and the existing tombstones are all
printable, and the op 500 tombstone stays identical to #58700's and
branch-4.x's. `BdbjeJournalDataProcNodeTest` reads an op 500 record and a
retired PL/SQL record in their written form and checks the rows, and a live
`OP_SAVE_NEXTID` r
ecord still shows its payload.
For scale: op 500 only exists in journals of unreleased branch-4.1/4.2
builds from between #67630 and #68781 on which the off-by-default
`enable_lance_index_mutation` was turned on, and only until a checkpoint
deletes those journals. The failure was limited to that one debug-mode
statement; replay and checkpointing never read the payload. branch-4.1/4.2 have
the same proc node and the same op 500 tombstone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
