github-actions[bot] commented on code in PR #69575:
URL: https://github.com/apache/doris/pull/69575#discussion_r4367233851
##########
fe/fe-core/src/main/java/org/apache/doris/journal/JournalEntity.java:
##########
@@ -913,6 +913,12 @@ public void readFields(DataInput in) throws IOException {
isRead = true;
break;
}
+ case OperationType.OP_LANCE_INDEX_JOB_UPSERT: {
+ // Text-framed JSON of the removed branch-4.x Lance index job
framework; consumed and ignored.
+ Text.readString(in);
Review Comment:
[P3] Retain a printable payload for the retired journal record
When an operator enables `enable_bdbje_debug_mode` and inspects a historical
op500 entry with `SHOW PROC '/bdbje/<db>/<journalId>'`, this branch succeeds
but leaves `JournalEntity.data` null. `BDBDebugger.getJournalEntity()`
consequently returns a non-null entity, and
`BdbjeJournalDataProcNode.fetchResult()` calls
`entity.entity.getData().toString()`, so the inspection fails with
`NullPointerException`. Retain the consumed JSON in an inert `Text` payload, or
make the debug consumer handle tombstone payloads; replay can still ignore the
record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
