github-actions[bot] commented on code in PR #69526:
URL: https://github.com/apache/doris/pull/69526#discussion_r4368483369
##########
fe/be-java-extensions/hadoop-deps/src/main/java/org/apache/hadoop/fs/FileSystem.java:
##########
@@ -3642,13 +3653,628 @@ public static Class<? extends FileSystem>
getFileSystemClass(String scheme,
* @return the initialized filesystem.
* @throws IOException problems loading or initializing the FileSystem
*/
+ // DORIS-PATCH: TVF policy is checked against the frozen configuration used
by the consumer.
+ public static int getDorisTvfGuardVersion() {
+ return 1;
+ }
+
+ public static final class TvfGuard {
+ public static final String POLICY_KEY = "fs.doris.tvf.remote.paths";
+ public static final String NATIVE_POLICY = "native";
+ public static final String JAVA_READ_POLICY = "java-read";
+ public static final String ROOT_KEY = "fs.doris.tvf.root";
+ public static final String PATH_KEY = "fs.doris.tvf.path";
+ public static final String CONTEXT_KEY = "fs.doris.tvf.context";
+ private static final ThreadLocal<Context> LAST_NATIVE_CONTEXT = new
ThreadLocal<>();
+
+ private TvfGuard() {
+ }
+
+ public static final class Rule {
+ private final String filesystem;
+ private final String path;
+ private final boolean descendants;
+
+ public Rule(String filesystem, String path, boolean descendants) {
+ this.filesystem = filesystem;
+ this.path = path;
+ this.descendants = descendants;
+ }
+ }
+
+ public static String encode(List<Rule> rules) {
+ if (FileSystem.getDorisTvfGuardVersion() != 1) {
+ throw new IllegalStateException("TVF Hadoop runtime policy version
mismatch");
+ }
+ try {
+ java.io.ByteArrayOutputStream bytes = new
java.io.ByteArrayOutputStream();
+ java.io.DataOutputStream out = new java.io.DataOutputStream(bytes);
+ out.writeInt(1);
+ out.writeInt(rules.size());
+ for (Rule rule : rules) {
+ out.writeUTF(rule.filesystem);
+ out.writeUTF(rule.path);
+ out.writeBoolean(rule.descendants);
+ }
+ out.flush();
+ return
java.util.Base64.getEncoder().encodeToString(bytes.toByteArray());
+ } catch (IOException e) {
+ throw new IllegalArgumentException("Cannot encode TVF Hadoop route
policy", e);
+ }
+ }
+
+ private static IOException rejected() {
+ return new IOException("Hadoop TVF requires a proven remote filesystem
route. "
+ + "Use local() with LOCAL TVF privileges and secure-path
restrictions.");
+ }
+
+ private static Configuration freeze(Configuration conf) throws IOException
{
+ // Service providers (notably HDFS) register their default/site
resources on first load.
+ // Load them before copying raw values, as an ordinary FileSystem lookup
does.
+ if (!FILE_SYSTEMS_LOADED) {
+ loadFileSystems();
+ }
+ if (conf instanceof FrozenConfiguration) {
+ return conf;
+ }
+ return new FrozenConfiguration(conf);
+ }
+
+ private static Configuration prepare(Configuration conf) throws
IOException {
+ String policy = conf.getRaw(POLICY_KEY);
+ if (policy == null || policy.isEmpty()) {
+ return conf;
+ }
+ Configuration frozen = freeze(conf);
+ Context context = ((FrozenConfiguration) frozen).context;
+ if (NATIVE_POLICY.equals(policy)) {
+ context.checkNative(frozen.getRaw(ROOT_KEY), frozen.getRaw(PATH_KEY));
+ } else if (JAVA_READ_POLICY.equals(policy)) {
+ context.checkJava(new Path(frozen.getRaw(PATH_KEY)));
+ } else {
+ context.checkRules(policy);
+ }
+ return frozen;
+ }
+
+ public static void check(URI ignored, Configuration conf) throws
IOException {
+ prepare(conf);
+ }
+
+ public static void clearNativeContext() {
+ LAST_NATIVE_CONTEXT.remove();
+ }
+
+ public static Context takeNativeContext() {
+ Context result = LAST_NATIVE_CONTEXT.get();
+ LAST_NATIVE_CONTEXT.remove();
+ return result;
+ }
+
+ public static Configuration prepareJavaRead(Configuration conf, Path path,
String marker) throws IOException {
+ if (marker == null || marker.isEmpty()) {
+ return conf;
+ }
+ if (!NATIVE_POLICY.equals(marker)) {
+ throw rejected();
+ }
+ Configuration request = new Configuration(conf);
+ request.set(POLICY_KEY, JAVA_READ_POLICY);
+ request.set(ROOT_KEY, path.toUri().toString());
+ request.set(PATH_KEY, path.toString());
+ return prepare(request);
+ }
+
+ public static void checkJavaRead(FileSystem fs, Path path, String marker)
throws IOException {
+ if (marker == null || marker.isEmpty()) {
+ return;
+ }
+ if (!NATIVE_POLICY.equals(marker)) {
+ throw rejected();
+ }
+ // The marker is request-owned, never inferred from an unmarked cached
filesystem.
+ Configuration conf = fs.getConf();
+ if (JAVA_READ_POLICY.equals(conf.getRaw(POLICY_KEY))) {
+ // S3A derives a Configuration for bucket options. Its copy preserves
our internal
+ // marker and raw snapshot values, but not the private Configuration
subclass.
+ ((FrozenConfiguration) freeze(conf)).context.checkJava(path);
+ } else {
+ throw rejected();
+ }
+ }
+
+ private static final class FrozenConfiguration extends Configuration {
+ private final Context context;
+
+ private FrozenConfiguration(Configuration source) throws IOException {
+ super(false);
+ setClassLoader(source.getClassLoader());
+ java.util.SortedMap<String, String> values = new java.util.TreeMap<>();
+ for (Map.Entry<String, String> entry : source) {
+ String key = entry.getKey();
+ String value = source.getRaw(key);
+ set(key, value);
+ if (!PATH_KEY.equals(key) && !ROOT_KEY.equals(key) &&
!CONTEXT_KEY.equals(key)) {
+ values.put(key, value);
+ }
+ }
+ try {
+ java.security.MessageDigest digest =
java.security.MessageDigest.getInstance("SHA-256");
+ java.io.DataOutputStream output = new java.io.DataOutputStream(
+ new java.security.DigestOutputStream(new java.io.OutputStream() {
+ @Override
+ public void write(int value) {
+ }
+
+ @Override
+ public void write(byte[] values, int offset, int length) {
+ }
+ }, digest));
+ for (Map.Entry<String, String> entry : values.entrySet()) {
+ for (String value : new String[] {entry.getKey(),
entry.getValue()}) {
+ // Preserve raw Java code units, including unpaired surrogates.
UTF-8 replacement
+ // would give a literal '?' and an unpaired surrogate the same
cache profile.
+ output.writeInt(value.length());
+ output.writeChars(value);
+ }
+ }
+ output.flush();
+ StringBuilder identity = new StringBuilder();
+ for (byte value : digest.digest()) {
+ identity.append(Character.forDigit((value & 255) >>> 4, 16));
+ identity.append(Character.forDigit(value & 15, 16));
+ }
+ set(CONTEXT_KEY, identity.toString());
+ } catch (java.security.NoSuchAlgorithmException e) {
+ throw new IOException("SHA-256 is required for TVF Hadoop cache
isolation");
+ }
+ context = new Context(this);
+ }
+ }
+
+ public static final class Context {
+ private final Configuration conf;
+ private final Map<String, String> routingKeys = new HashMap<>();
+
+ private Context(Configuration conf) {
+ this.conf = conf;
+ for (Map.Entry<String, String> entry : conf) {
+ String key = entry.getKey();
+ if ("fs.defaultFS".equals(key) || "fs.default.name".equals(key)
+ || key.startsWith("fs.viewfs.") || (key.startsWith("fs.") &&
key.endsWith(".impl"))) {
+ routingKeys.put(key, entry.getValue());
+ }
+ }
+ }
+
+ private EffectiveRoute route(boolean descendants) {
+ return new EffectiveRoute(routingKeys, descendants, conf);
+ }
+
+ public String profile() {
+ return conf.getRaw(CONTEXT_KEY);
+ }
+
+ public boolean isDirectRemote() throws IOException {
+ String root = conf.getRaw(ROOT_KEY);
+ if (root == null) {
+ throw rejected();
+ }
+ try {
+ URI uri = nativeUri(root);
+ return route(false).provider(uri.getScheme()) ==
Route.Provider.REMOTE;
+ } catch (RuntimeException | URISyntaxException e) {
+ throw rejected();
+ }
+ }
+
+ private static URI nativeUri(String root) throws URISyntaxException {
+ root = root.trim();
+ if (root.isEmpty() || "default".equals(root)) {
+ throw new URISyntaxException("", "Unproven native filesystem");
+ }
+ return new URI(root.contains("://") ? root : "hdfs://" + root);
+ }
+
+ public void checkNative(String root, String path) throws IOException {
+ if (root == null || path == null || path.isEmpty()) {
+ throw rejected();
+ }
+ try {
+ URI uri = nativeUri(root);
+ String actual = new Path(path).toUri().getPath();
+ route(false).checkRoute(uri, actual, new HashSet<>());
+ } catch (RuntimeException | URISyntaxException e) {
+ throw rejected();
+ }
+ }
+
+ private void checkJava(Path path) throws IOException {
+ try {
+ URI uri = path.toUri();
+ route(false).checkRoute(uri, uri.getPath(), new HashSet<>());
+ } catch (RuntimeException | URISyntaxException e) {
+ throw rejected();
+ }
+ }
+
+ private void checkRules(String policy) throws IOException {
+ try {
+ byte[] bytes = java.util.Base64.getDecoder().decode(policy);
+ java.io.DataInputStream in = new java.io.DataInputStream(new
java.io.ByteArrayInputStream(bytes));
+ int version = in.readInt();
+ int count = in.readInt();
+ if (version != 1 || count <= 0 || count > in.available() / 5) {
+ throw rejected();
+ }
+ for (int i = 0; i < count; i++) {
+ URI filesystem = new URI(in.readUTF());
+ String path = in.readUTF();
+ boolean descendants = in.readBoolean();
+ route(descendants).checkRoute(filesystem, path, new HashSet<>());
+ }
+ if (in.available() != 0) {
+ throw rejected();
+ }
+ } catch (RuntimeException | URISyntaxException e) {
+ throw rejected();
+ }
+ }
+ }
+
+ private static final class EffectiveRoute extends Route {
+ private final Configuration conf;
+
+ private EffectiveRoute(Map<String, String> properties, boolean
descendants, Configuration conf) {
+ super(properties, descendants);
+ this.conf = conf;
+ }
+
+ @Override
+ protected String property(String key) {
+ return conf.get(key);
+ }
+
+ @Override
+ protected Provider provider(String scheme) {
+ if ("file".equalsIgnoreCase(scheme)) {
+ return Provider.LOCAL;
+ }
+ try {
+ String implementation = FileSystem.getFileSystemClass(scheme,
conf).getName();
+ if (Arrays.asList("io.juicefs.JuiceFileSystem",
"org.apache.hadoop.fs.ozone.OzoneFileSystem",
+ "org.apache.hadoop.fs.ozone.RootedOzoneFileSystem",
"org.apache.hadoop.fs.cosn.CosNFileSystem",
+
"com.qcloud.chdfs.fs.CHDFSHadoopFileSystemAdapter").contains(implementation)) {
+ return Provider.REMOTE;
+ }
+ return implementationProvider(implementation);
+ } catch (IOException | RuntimeException e) {
+ return Provider.UNKNOWN;
+ }
+ }
+ }
+
+ public static class Route {
+ protected enum Provider {
+ REMOTE,
+ LOCAL,
+ MOUNT_TABLE,
+ DYNAMIC,
+ UNKNOWN
+ }
+
+ protected static final Set<String> REMOTE_SCHEMES = new
HashSet<>(Arrays.asList(
+ "hdfs", "s3a", "s3n", "oss", "ofs", "jfs", "abfs", "abfss", "wasb",
"wasbs", "gs", "cosn"));
+ protected static final Set<String> REMOTE_IMPLEMENTATIONS = new
HashSet<>(Arrays.asList(
+ "org.apache.hadoop.hdfs.DistributedFileSystem",
+ "org.apache.hadoop.fs.s3a.S3AFileSystem",
+ "org.apache.hadoop.fs.azurebfs.AzureBlobFileSystem",
+ "org.apache.hadoop.fs.azurebfs.SecureAzureBlobFileSystem",
+ "org.apache.hadoop.fs.azure.NativeAzureFileSystem",
+ "org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystem",
+ "com.aliyun.jindodata.oss.JindoOssFileSystem",
+ "org.apache.hadoop.fs.obs.OBSFileSystem",
+ "com.google.cloud.hadoop.fs.gcs.GoogleHadoopFileSystem"));
+
+ private final boolean descendants;
+ private final Map<String, String> properties;
+
+ public Route(Map<String, String> properties, boolean descendants) {
+ // Both callers supply a statement-local snapshot that is never
mutated afterward.
+ this.properties = properties;
+ this.descendants = descendants;
+ }
+
+ private List<URI> defaults() throws URISyntaxException {
+ List<URI> defaults = new ArrayList<>();
+ for (String key : Arrays.asList("fs.defaultFS", "fs.default.name")) {
+ String value = property(key);
+ if (value != null) {
+ value = selector(value).trim();
+ // FileSystem.fixName treats slash-free host[:port] strings as
HDFS defaults.
+ defaults.add(new URI("local".equals(value) ? "file:///"
+ : (value.indexOf('/') < 0 ? "hdfs://" + value : value)));
+ }
+ }
+ if (defaults.isEmpty()) {
+ defaults.add(new URI("file:///"));
+ }
+ return defaults;
+ }
+
+ public void checkRoute(URI filesystem, String path, Set<String>
activeTables) throws URISyntaxException {
+ if (filesystem.getScheme() == null) {
+ for (URI defaultFs : defaults()) {
+ checkViewFsEnabled(defaultFs, path, activeTables);
+ }
+ return;
+ }
+ if (filesystem.getAuthority() == null) {
+ boolean completed = false;
+ for (URI defaultFs : defaults()) {
+ if (filesystem.getScheme().equals(defaultFs.getScheme()) &&
defaultFs.getAuthority() != null) {
+ checkViewFsEnabled(defaultFs, path, activeTables);
+ completed = true;
+ }
+ }
+ if (completed) {
+ return;
+ }
+ }
+ checkViewFsEnabled(filesystem, path, activeTables);
+ }
+
+ protected Provider provider(String scheme) {
+ if ("file".equalsIgnoreCase(scheme)) {
+ return Provider.LOCAL;
+ }
+ String implementation = property("fs." + scheme + ".impl");
+ if (implementation != null) {
+ implementation = selector(implementation).trim();
+ return implementationProvider(implementation);
+ }
+ if ("viewfs".equals(scheme)) {
+ return Provider.MOUNT_TABLE;
+ }
+ return REMOTE_SCHEMES.contains(scheme) ? Provider.REMOTE :
Provider.UNKNOWN;
+ }
+
+ protected Provider implementationProvider(String implementation) {
+ if ("org.apache.hadoop.fs.LocalFileSystem".equals(implementation)
+ ||
"org.apache.hadoop.fs.RawLocalFileSystem".equals(implementation)) {
+ return Provider.LOCAL;
+ }
+ if
("org.apache.hadoop.fs.viewfs.ViewFileSystem".equals(implementation)) {
+ return Provider.MOUNT_TABLE;
+ }
+ if
("org.apache.hadoop.fs.viewfs.ViewFileSystemOverloadScheme".equals(implementation)
+ ||
"org.apache.hadoop.hdfs.ViewDistributedFileSystem".equals(implementation)) {
+ return Provider.DYNAMIC;
+ }
+ return REMOTE_IMPLEMENTATIONS.contains(implementation) ?
Provider.REMOTE : Provider.UNKNOWN;
+ }
+
+ private String[] targets(String key, String prefix) {
+ String value = selector(property(key));
+ // InodeTree treats SINGLE, SINGLE_FALLBACK and MERGE_SLASH as one URI.
+ // Commas delimit targets only for MERGE and NFLY links.
+ String entry = key.substring(prefix.length());
+ boolean multiple = entry.startsWith("linkMerge.") ||
entry.startsWith("linkNfly.");
+ return multiple ? value.split(",", -1) : new String[] {value};
+ }
+
+ private void checkGlobTargets(String key, String prefix, Set<String>
activeTables) throws URISyntaxException {
+ for (String target : targets(key, prefix)) {
+ if (target.isEmpty()) {
+ reject();
+ }
+ URI uri = new URI(target);
+ // Listing can touch any descendant of a selected mount. Reuse the
same route
+ // interpreter for nested tables instead of assuming their root is
representative.
+ String path = uri.getPath() == null ? "/" : uri.getPath();
+ checkRoute(uri, (path.endsWith("/") ? path : path + "/") + "*",
activeTables);
+ }
+ }
+
+ private void checkViewFsEnabled(URI filesystem, String path, Set<String>
activeTables) {
+ String scheme = filesystem.getScheme();
+ Provider provider = provider(scheme);
+ if (provider == Provider.LOCAL || provider == Provider.UNKNOWN ||
provider == Provider.DYNAMIC) {
+ reject();
+ }
+ if (provider != Provider.MOUNT_TABLE) {
+ return;
+ }
+ if (!path.startsWith("/")) {
+ // Java resolves relative paths against the selected filesystem's
working directory.
+ // Its user/home configuration is not a proven absolute mount-table
path here.
+ reject();
+ }
+ String table = filesystem.getAuthority();
+ String ignorePort =
property("fs.viewfs.ignore.port.in.mount.table.name");
+ if (ignorePort != null &&
Boolean.parseBoolean(selector(ignorePort).trim())
+ && table != null && filesystem.getPort() != -1) {
+ table = filesystem.getHost();
+ if (table == null) {
+ reject();
+ }
+ }
+ if (table == null || table.isEmpty()) {
+ table = property("fs.viewfs.mounttable.default.name.key");
+ table = table == null ? "default" : selector(table);
+ }
+ // Nested ViewFS cycles or arbitrarily deep delegation cannot
establish remote storage.
+ if (activeTables.size() >= 32 || !activeTables.add(table)) {
+ reject();
+ }
+ try {
+ String prefix = "fs.viewfs.mounttable." + table + ".";
+ String source = "";
+ List<String> selectedKeys = new ArrayList<>();
+ List<String> mountSources = new ArrayList<>();
+ String fallback = null;
+ String rootMerge = null;
+ for (String key : properties.keySet()) {
+ if (!key.startsWith(prefix)) {
+ continue;
+ }
+ String entry = key.substring(prefix.length());
+ if (entry.equals("linkFallback")) {
+ fallback = key;
+ continue;
+ }
+ if (entry.equals("linkMergeSlash")) {
+ rootMerge = key;
+ continue;
+ }
+ if (entry.startsWith("linkRegex")) {
+ // Regex interception rewrites runtime paths before ordinary
mount resolution.
+ reject();
+ }
+ int slash = entry.indexOf('/');
+ if (slash < 0 || !(entry.startsWith("link.") ||
entry.startsWith("linkMerge.")
+ || entry.startsWith("linkNfly."))) {
+ continue;
+ }
+ String candidate = entry.substring(slash);
+ // InodeTree splits source components and discards trailing empty
components.
+ while (candidate.length() > 1 && candidate.endsWith("/")) {
+ candidate = candidate.substring(0, candidate.length() - 1);
+ }
+ mountSources.add(candidate);
+ if (!(path.equals(candidate) || path.startsWith(candidate + "/")))
{
+ continue;
+ }
+ if (candidate.length() > source.length()) {
+ source = candidate;
+ selectedKeys.clear();
+ }
+ if (candidate.equals(source)) {
+ selectedKeys.add(key);
+ }
+ }
+ if (descendants && hasGlob(path)) {
+ String literal = path.substring(0, firstGlob(path));
Review Comment:
[P2] Resolve glob escapes before admitting ViewFS read routes
With LOCAL disabled, an HDFS/FILE read whose `uri` has runtime value
`viewfs://cluster/da\ta/*.csv` (one literal backslash),
`fs.defaultFS=viewfs://cluster`,
`fs.viewfs.mounttable.cluster.link./data=file:///tmp`,
`fs.viewfs.mounttable.cluster.linkFallback=hdfs://remote/base`, `format=csv`
and `csv_schema=id:int` passes admission: this literal-prefix check and the
effective-configuration guard miss `/data` and select the remote fallback.
However, `DFSFileSystem.globListWithLimit` sends the pattern to Hadoop's
[Globber](https://github.com/apache/hadoop/blob/rel/release-3.4.2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java#L261-L291),
which removes the backslash before calling `listStatus` on `/data`. ViewFS
consequently lists FE-local `/tmp` before `HdfsTableValuedFunction` checks
returned paths. Matches are rejected afterward, while no matches yield an empty
result with the declared schema, permitting local metadata probing outside the
constraine
d LOCAL contract. This concerns glob unescaping, distinct from the earlier
direct/inherited mount findings. Check the routes produced by Hadoop's glob
expansion/unescaping before discovery, and cover this
escaped-prefix/local-mount case plus a remote control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
