github-actions[bot] commented on code in PR #68615:
URL: https://github.com/apache/doris/pull/68615#discussion_r4140957058
##########
be/test/format_v2/table/lance_reader_test.cpp:
##########
@@ -912,6 +912,15 @@ TEST(LanceTableReaderVectorSearchTest,
MultiVectorScoresFiltersOffsetsAndIndexed
}
EXPECT_TRUE(reader.close().ok());
if (indexed) {
+ // Warm searches still perform scoring even when every
index partition is cached.
+ for (const char* name :
+ {"LanceIndexPartitionLoadTime",
"LanceIndexCpuQueueWaitTime",
+ "LanceIndexSearchTime", "LanceIndexQueryPrepareTime",
+ "LanceIndexDistanceTopKTime",
"LanceIndexResultMaterializeTime"}) {
+ auto* counter = profile.get_counter(name);
+ ASSERT_NE(nullptr, counter) << name;
+ EXPECT_GT(counter->value(), 0) << name;
Review Comment:
[P2] Check ANN timer emission without requiring every duration to be
positive. The pinned lance-c timing test explicitly allows zero nanoseconds for
short or uncontended stages; this four-result indexed scan requires six
independent timers to be `> 0`. A valid zero CPU queue wait or fast stage
therefore fails the BE test even when the metrics and results are correct.
Assert presence and unit/kind, or use a workload with a guaranteed measurable
stage for any positive-value check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
