github-actions[bot] commented on code in PR #68615:
URL: https://github.com/apache/doris/pull/68615#discussion_r4132705390
##########
be/src/format_v2/table/lance_reader.cpp:
##########
@@ -697,6 +697,55 @@ void LanceTableReader::_init_scanner_profile() {
TUnit::UNIT, LANCE_READER_PROFILE,
1)},
};
_lance_time_metrics = {
+ // Partition stages accumulate across concurrent work and overlap
their parent timers.
+ // DistanceTopK includes fused candidate filtering, scoring, and
heap updates.
+ {"index_open_time", ADD_CHILD_TIMER_WITH_LEVEL(_scanner_profile,
"LanceIndexOpenTime",
+
LANCE_READER_PROFILE, 1)},
+ {"index_partition_load_time",
+ ADD_CHILD_TIMER_WITH_LEVEL(_scanner_profile,
"LanceIndexPartitionLoadTime",
+ LANCE_READER_PROFILE, 1)},
+ {"index_partition_prepare_time",
+ ADD_CHILD_TIMER_WITH_LEVEL(_scanner_profile,
"LanceIndexPartitionPrepareTime",
+ LANCE_READER_PROFILE, 1)},
+ {"index_prefilter_wait_time",
+ ADD_CHILD_TIMER_WITH_LEVEL(_scanner_profile,
"LanceIndexPrefilterWaitTime",
+ LANCE_READER_PROFILE, 1)},
+ {"index_cpu_queue_wait_time",
+ ADD_CHILD_TIMER_WITH_LEVEL(_scanner_profile,
"LanceIndexCpuQueueWaitTime",
+ LANCE_READER_PROFILE, 1)},
+ {"index_search_time",
Review Comment:
[P2] Publish ANN timings when a search stops before EOF. These new counters
are filled only by lance-c's statistics callback, which the pinned source runs
when the result stream is polled to EOF. For a single indexed split with
top_k=2048, a 1024-row scanner batch, and SQL LIMIT 512, Doris can return a
full first block, satisfy its pushed local limit, and close the scanner without
another Lance poll. All the new ANN timers stay zero although search work ran.
The added test drains to EOF, so it misses this path. Publish a partial summary
on stream retirement or expose a snapshot before close, and cover a full-block
early stop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
