github-actions[bot] commented on code in PR #68615:
URL: https://github.com/apache/doris/pull/68615#discussion_r4142319562
##########
thirdparty/patches/lance-c-foyer.patch:
##########
@@ -1034,7 +922,7 @@ index 0000000..9a10e43
+ let original = self.cache.unwrap_store(original);
+ let reader = DataCacheReader {
+ cache: self.cache.clone(),
-+ store_prefix: store_prefix.to_owned(),
++ store_prefix: format!("{}\0{store_prefix}",
origin_namespace(&original)),
Review Comment:
[P2] Keep Foyer keys reusable across dataset opens.
`origin_namespace(&original)` adds a random UUID for each object-store
instance, but `Dataset::with_object_store_wrappers` replaces the registry's
store and the shared registry retains only a weak reference. The next Doris
reader therefore gets a new origin/UUID and misses every data and size block
admitted by the previous query, including persisted disk entries; the added
repeated-open test even expects remote reads on its second handle. With the
data cache enabled by default, ordinary warm queries cannot benefit from its
100 GB disk tier. Keep a verified backend identity or shared origin stable
across opens, and test a close/reopen warm scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
