u70b3 commented on code in PR #66671: URL: https://github.com/apache/doris/pull/66671#discussion_r3867644947
########## fe/fe-core/src/main/java/org/apache/doris/datasource/lance/LanceLogicalIndex.java: ########## @@ -0,0 +1,60 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.datasource.lance; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Objects; + +/** Immutable logical index metadata read from one Lance dataset snapshot. */ +public final class LanceLogicalIndex { + private final String name; + private final List<String> columns; + private final String indexType; + private final String properties; Review Comment: Thanks — I went back and cross-checked this against the [agreed v5.1 / final 4.2 design](https://github.com/apache/doris/issues/66497#issuecomment-5301314544) and the [earlier scope review](https://github.com/apache/doris/issues/66497#issuecomment-5301637401). That reviewed contract intentionally keeps this TVF to physical index identity: exactly `CatalogName`, `DatabaseName`, `TableName`, `IndexName`, `IndexUuid`, and `DatasetVersion`. Fragment and row coverage were explicitly deferred, so even the interim `FragmentCount` I added in response to the previous question needs to stay out of this PR. There is also a semantic issue to resolve first: `Index.fragments()` can contain fragment IDs that no longer exist in the latest dataset. Fragment count, logical row count, and physical row count therefore need an agreed current-vs-historical interpretation and may require additional metadata reads. Adding any of these fields would change the previously reviewed contract, so I think we should discuss and agree on that design again with the earlier reviewers under #66497 before implementing it. I have removed the interim `FragmentCount` change and aligned the code, tests, and PR description with the six-column contract. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
