u70b3 commented on code in PR #66671: URL: https://github.com/apache/doris/pull/66671#discussion_r3860700969
########## fe/fe-core/src/main/java/org/apache/doris/datasource/lance/LanceLogicalIndex.java: ########## @@ -0,0 +1,60 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.datasource.lance; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Objects; + +/** Immutable logical index metadata read from one Lance dataset snapshot. */ +public final class LanceLogicalIndex { + private final String name; + private final List<String> columns; + private final String indexType; + private final String properties; Review Comment: Yes — the SDK exposes it: each physical index segment's `Index.fragments()` carries the covered fragment ids. Added a nullable `FragmentCount` BIGINT column to `lance_index_entries` (aaf78dba5d), so one row now tells exactly how many fragments its segment covers (e.g. 2 for the `vs_ivf_pq_f32` fixture, 1 for `nested_index`). Two semantics worth noting: - Legacy index metadata may not carry a fragment list; that surfaces as NULL, never as 0, so unknown coverage can't be misread as an empty segment. - Not added to SHOW INDEX: its logical view keeps the MySQL-shaped fixed columns and has no segment granularity — per-segment coverage belongs to this physical inspection TVF. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
