u70b3 commented on code in PR #66671: URL: https://github.com/apache/doris/pull/66671#discussion_r3867644947
########## fe/fe-core/src/main/java/org/apache/doris/datasource/lance/LanceLogicalIndex.java: ########## @@ -0,0 +1,60 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.datasource.lance; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Objects; + +/** Immutable logical index metadata read from one Lance dataset snapshot. */ +public final class LanceLogicalIndex { + private final String name; + private final List<String> columns; + private final String indexType; + private final String properties; Review Comment: Thanks — row count and physical rows would be valuable for richer diagnostics. After checking the pinned Lance semantics, however, `Index.fragments()` can contain fragment IDs that no longer exist in the latest dataset. Exact per-segment row counts therefore cannot be derived from this TVF's single latest snapshot without defining current-vs-historical coverage semantics and performing additional metadata reads. I'm using option A and keeping this PR on the accepted v5.1 minimal contract: exactly six columns (`CatalogName`, `DatabaseName`, `TableName`, `IndexName`, `IndexUuid`, `DatasetVersion`). I removed the interim `FragmentCount` change and aligned the code, tests, and PR description. Row/fragment coverage — including raw vs current fragment counts and logical vs physical row semantics — should be designed and reviewed as a separate follow-up under #66497. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
