HappenLee commented on code in PR #66788:
URL: https://github.com/apache/doris/pull/66788#discussion_r3790911022


##########
fe/fe-core/src/main/java/org/apache/doris/load/StreamLoadHandler.java:
##########
@@ -269,7 +270,8 @@ public void generatePlan(OlapTable table) throws 
UserException {
                     "get table read lock timeout, database=" + request.getDb() 
+ ",table=" + table.getName());
         }
         try {
-            NereidsStreamLoadTask streamLoadTask = 
NereidsStreamLoadTask.fromTStreamLoadPutRequest(request);
+            NereidsStreamLoadTask streamLoadTask = 
NereidsStreamLoadTask.fromTStreamLoadPutRequest(
+                    request, 
VariableMgr.getDefaultSessionVariable().enableHyperscanFallback);

Review Comment:
   Fixed in 68f72081dcc. RPC stream load planning now reads 
`enable_hyperscan_fallback` from the request-scoped `ConnectContext` 
session-variable snapshot instead of the mutable global default. Added 
`StreamLoadHandlerTest.testGeneratePlanUsesSessionVariableSnapshot` to verify 
that a snapshot value differing from the global default is propagated. Verified 
with `./run-fe-ut.sh --run org.apache.doris.load.StreamLoadHandlerTest` (4 
tests, 0 failures); Maven validate/checkstyle also passed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to