HappenLee commented on code in PR #66788:
URL: https://github.com/apache/doris/pull/66788#discussion_r3790898705
##########
fe/fe-core/src/main/java/org/apache/doris/planner/GroupCommitPlanner.java:
##########
@@ -123,7 +123,8 @@ public GroupCommitPlanner(Database db, OlapTable table,
List<String> targetColum
.setMergeType(TMergeType.APPEND).setThriftRpcTimeoutMs(5000).setLoadId(queryId)
.setTrimDoubleQuotes(true).setGroupCommitMode(groupCommit)
.setStrictMode(ConnectContext.get().getSessionVariable().enableInsertStrict);
- NereidsStreamLoadTask streamLoadTask =
NereidsStreamLoadTask.fromTStreamLoadPutRequest(streamLoadPutRequest);
+ NereidsStreamLoadTask streamLoadTask =
NereidsStreamLoadTask.fromTStreamLoadPutRequest(
+ streamLoadPutRequest,
ConnectContext.get().getSessionVariable().enableHyperscanFallback);
Review Comment:
Thanks for pointing this out. We agree that prepared Group Commit planner
reuse should be invalidated through a unified session-variable fingerprint,
instead of adding another option-specific reuse check here. Since that requires
a broader change to the common cache invalidation mechanism, we will address it
in a follow-up PR and track it with a Jira TODO, rather than expanding the
scope of this PR. We will keep this thread open until the follow-up is tracked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
