HappenLee commented on code in PR #66788:
URL: https://github.com/apache/doris/pull/66788#discussion_r3786107532
##########
be/src/exprs/function/like.cpp:
##########
@@ -487,8 +602,21 @@ Status FunctionLikeBase::regexp_fn(const LikeSearchState*
state, const ColumnStr
}
// hyperscan compile expression to database and allocate scratch space
+bool FunctionLikeBase::should_fallback_to_re2(std::string_view regexp) {
Review Comment:
Fixed in eecadf3d2b7. I moved the bounded-repeat detector into the shared
be/src/util/hyperscan_util utility and now invoke it before every direct
Hyperscan compiler: LIKE/REGEXP, no-index MATCH_REGEXP, inverted regexp v1,
search-DSL regexp v2, and multi-match. Paths without an RE2 fallback reject the
pattern with InvalidArgument before compilation. Added regressions for the
no-index, both indexed implementations, and multi-pattern paths; the targeted
BE run passed all 40 tests.
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -3513,6 +3515,10 @@ public void
checkAnnIndexCandidateRowsPercentThreshold(String value) {
description = "Enable extended regular expressions, support
look-around zero-width assertions")
public boolean enableExtendedRegex = false;
+ @VarAttrDef.VarAttr(name = ENABLE_HYPERSCAN_FALLBACK, needForward = true,
affectQueryResultInExecution = true,
Review Comment:
Fixed in eecadf3d2b7. Broker and routine jobs now capture
enable_hyperscan_fallback in their persisted session-variable map (old replay
records without the key default to true), and the value is propagated through
broker/cloud/routine/stream task descriptors into both legacy and Nereids
coordinator query options. SQL group-commit/insert stream loads capture the
current session value; RPC stream loads use the persisted global default. Added
initial-dispatch coverage for broker/stream options and replay-compatibility
coverage for routine load; the targeted FE run passed all 32 tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
