yiguolei commented on code in PR #10896:
URL: https://github.com/apache/doris/pull/10896#discussion_r922675020
##########
be/src/olap/rowset/segment_v2/page_io.h:
##########
@@ -46,7 +46,7 @@ namespace segment_v2 {
struct PageReadOptions {
// block to read page
- doris::io::FileReader* file_reader = nullptr;
+ io::FileReader* file_reader = nullptr;
Review Comment:
why not use shared pointer here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
