yiguolei commented on code in PR #10896:
URL: https://github.com/apache/doris/pull/10896#discussion_r922671321
##########
be/src/olap/rowset/segment_v2/column_reader.h:
##########
@@ -64,7 +64,7 @@ struct ColumnReaderOptions {
};
struct ColumnIteratorOptions {
- io::FileReader* file_reader = nullptr;
+ io::FileReaderPtr file_reader = nullptr;
Review Comment:
the pointer is called too many times, shared ptr may have performance issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
