yiguolei commented on code in PR #10896:
URL: https://github.com/apache/doris/pull/10896#discussion_r922671115
##########
be/src/io/fs/file_reader.h:
##########
@@ -38,7 +40,11 @@ class FileReader {
virtual const Path& path() const = 0;
virtual size_t size() const = 0;
+
+ virtual bool closed() const = 0;
};
+using FileReaderPtr = std::shared_ptr<FileReader>;
Review Comment:
Have you test that there is no performance lost when change to use shared
ptr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
