jacktengg commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978709497
##########
be/src/vec/columns/column_string.h:
##########
@@ -229,6 +229,7 @@ class ColumnStr final : public COWHelper<IColumn,
ColumnStr<T>> {
void insert_many_strings_without_reserve(const StringRef* strings, size_t
num) {
Char* data = chars.data();
size_t offset = chars.size();
+ data += offset;
Review Comment:
> 如果这里不对的话，那么下面的offset 计算是不是也有问题？？
offset 计算没问题，是直接把最新的chars数组的总长度往pod_array里面push_back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
