jacktengg commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978687819
##########
be/src/vec/core/field.cpp:
##########
@@ -174,14 +174,14 @@ DECLARE_DECIMAL_COMPARISON(Decimal256)
template <>
bool decimal_equal(Decimal128V3 x, Decimal128V3 y, UInt32 xs, UInt32 ys) {
- return dec_equal(Decimal128V2(x.value), Decimal128V2(y.value), xs, ys);
Review Comment:
是的，decimal128V3的scale > 27时，会报错：
```
C++ exception with description "[E6] meet invalid scale: real_scale=30,
max_decimal_precision=27
0# doris::get_stack_trace(int, std::__cxx11::basic_string<char,
std::char_traits<char>, std::allocator<char> >) at
/mnt/disk2/tengjianping/doris-39/be/src/util/stack_util.cpp:62
1# doris::Exception::Exception(int, std::basic_string_view<char,
std::char_traits<char> > const&) at
/mnt/disk2/tengjianping/doris-39/be/src/common/exception.cpp:29
2# doris::Exception::Exception<unsigned int const&, unsigned
long>(int, std::basic_string_view<char, std::char_traits<char> > const&,
unsigned int const&, unsigned long&&) at
/mnt/disk2/tengjianping/doris-39/be/src/common/exception.h:44
3#
doris::vectorized::DataTypeDecimal<doris::vectorized::Decimal<__int128>
>::check_type_scale(unsigned int) at
/mnt/disk2/tengjianping/doris-39/be/src/vec/data_types/data_type_decimal.h:287
4#
doris::vectorized::DataTypeDecimal<doris::vectorized::Decimal<__int128>
>::DataTypeDecimal(unsigned int, unsigned int, unsigned int, unsigned int) at
/mnt/disk2/tengjianping/doris-39/be/src/vec/data_types/data_type_decimal.h:129
5#
doris::vectorized::DecimalComparison<doris::vectorized::Decimal<__int128>,
doris::vectorized::Decimal<__int128>, doris::vectorized::LessOp, true,
true>::compare(doris::vectorized::Decimal<__int128>,
doris::vectorized::Decimal<__int128>, unsigned int, unsigned int) at
/mnt/disk2/tengjianping/doris-39/be/src/vec/core/decimal_comparison.h:121
6# bool
doris::vectorized::dec_less<doris::vectorized::Decimal<__int128>
>(doris::vectorized::Decimal<__int128>, doris::vectorized::Decimal<__int128>,
unsigned int, unsigned int) at
/mnt/disk2/tengjianping/doris-39/be/src/vec/core/field.cpp:143
7# bool
doris::vectorized::decimal_less<doris::vectorized::Decimal128V3>(doris::vectorized::Decimal128V3,
doris::vectorized::Decimal128V3, unsigned int, unsigned int) at
/mnt/disk2/tengjianping/doris-39/be/src/vec/core/field.cpp:183
8#
doris::vectorized::ColumnDecimal<doris::vectorized::Decimal128V3>::compare_at(unsigned
long, unsigned long, doris::vectorized::IColumn const&, int) const at
/mnt/disk2/tengjianping/doris-39/be/src/vec/columns/column_decimal.cpp:54
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
