jacktengg commented on code in PR #48554:
URL: https://github.com/apache/doris/pull/48554#discussion_r1978697530
##########
be/src/vec/columns/column_string.h:
##########
@@ -229,6 +229,7 @@ class ColumnStr final : public COWHelper<IColumn,
ColumnStr<T>> {
void insert_many_strings_without_reserve(const StringRef* strings, size_t
num) {
Char* data = chars.data();
size_t offset = chars.size();
+ data += offset;
Review Comment:
这里不加的话，就会把column里面原有的数据给覆盖了，你看它下面是直接copy 到data：
```
if (length != 0) {
DCHECK(ptr != nullptr);
memcpy(data, ptr, length);
data += length;
}
```
之前的用法，应该是调用这个函数的时候，column原本都是没有数据的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
