HappenLee commented on code in PR #42930:
URL: https://github.com/apache/doris/pull/42930#discussion_r1823730879
##########
be/src/vec/exprs/table_function/vexplode_json_array.h:
##########
@@ -77,7 +74,7 @@ struct ParsedDataInt : public ParsedData<int64_t> {
}
} else if (v.IsDouble()) {
auto value = v.GetDouble();
- if (value > MAX_VALUE) {
+ if (static_cast<long double>(value) > MAX_VALUE) {
Review Comment:
why double max use int64_t::max?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
