HappenLee commented on code in PR #42930: URL: https://github.com/apache/doris/pull/42930#discussion_r1823729998
########## be/src/vec/exprs/table_function/vexplode_json_array.cpp: ########## @@ -144,7 +143,8 @@ void VExplodeJsonArrayTableFunction<DataImpl>::_insert_values_into_column(Mutabl size_t old_size = nullmap_column->size(); nullmap_column->resize(old_size + max_step); memcpy(nullmap_column->get_data().data() + old_size, - _parsed_data.get_null_flag_address(_cur_offset), max_step * sizeof(UInt8)); + _parsed_data.get_null_flag_address(cast_set<int>(_cur_offset)), Review Comment: why here need cast? not use cast_set to do the work where here really need int? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org