HappenLee commented on code in PR #42930:
URL: https://github.com/apache/doris/pull/42930#discussion_r1823726272
##########
be/src/vec/exprs/lambda_function/varray_map_function.cpp:
##########
@@ -109,23 +105,23 @@ class ArrayMapFunction : public LambdaFunction {
}
// here is the array column
- const ColumnArray& col_array = assert_cast<const
ColumnArray&>(*column_array);
+ const auto& col_array = assert_cast<const
ColumnArray&>(*column_array);
const auto& col_type = assert_cast<const
DataTypeArray&>(*type_array);
if (i == 0) {
- nested_array_column_rows = col_array.get_data_ptr()->size();
+ nested_array_column_rows =
static_cast<int>(col_array.get_data_ptr()->size());
Review Comment:
why here need cast？ not use `cast_set ` to do the work where here really
need int?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
